Sync clipToPadding with overflow on Android views#55563
Open
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Open
Sync clipToPadding with overflow on Android views#55563fabriziocucci wants to merge 1 commit intofacebook:mainfrom
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93248532. |
Summary: Pull Request resolved: facebook#55563 Changelog: [Internal] This change syncs the `clipToPadding` property with the `overflow` property on Android views to enable input systems to correctly identify which views are clipping their content. When `overflow` is set to `VISIBLE`, `clipToPadding` is set to `false`. For any other overflow value (e.g., `HIDDEN`, `SCROLL`), `clipToPadding` is set to `true`. The change is gated behind the `syncAndroidClipToPaddingWithOverflow` feature flag. Differential Revision: D93248532
fabriziocucci
force-pushed
the
export-D93248532
branch
from
fa4d5fb to
caa48a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This change syncs the
clipToPaddingproperty with theoverflowproperty on Android views to enable input systems to correctly identify which views are clipping their content.When
overflowis set toVISIBLE,clipToPaddingis set tofalse. For any other overflow value (e.g.,HIDDEN,SCROLL),clipToPaddingis set totrue.The change is gated behind the
syncAndroidClipToPaddingWithOverflowfeature flag.Differential Revision: D93248532